I'm missing an option to "Use system icons for files"
in FSB like Project Viewer has.
Sorry if this is a dupe, but I have many bugs to post
and am too lazy to check them all for dupes
currently. :-)
OS: Windows XP
Java Version: Sun Java 1.5.0_09-b03
jEdit Version: 4.3pre8
Submitted | vampire0 - 2006-11-09 - 14:30:04z | Assigned | kpouer |
---|---|---|---|
Priority | 5 | Category | core |
Status | Open | Group | None |
Resolution | None | Visibility | No |
2007-01-13 - 18:42:31z kpouer |
Logged In: YES user_id=285591 Originator: NO done for 4.3pre9 (check the File System Browser options) |
---|---|
2007-03-06 - 23:07:23z vampire0 |
Logged In: YES user_id=918212 Originator: YES Almost, it works for the files and folders in the lower (right) files view, but it doesn't work for drives/filesystems and it doesn't work for the directories and drives/filesystems in the upper (left) directory view. The custom icons should be used there too. |
2007-03-07 - 10:14:17z kpouer |
Logged In: YES user_id=285591 Originator: NO Hi, in fact the problem is in the VFS Browser itself but it is intended : The ParentDirectoryList always uses default VFSFile instead of VFS files given by the VFS itself There is a comment to explain that in the code line 189 of class BrowserView : // create a DirectoryEntry manually // instead of using _vfs._getFile() // since so many VFS's have broken // implementations of this method I have no idea if it is still true. Maybe a new experimental feature would be to use the vfs._getFile() if the option is checked |
2007-03-08 - 23:08:18z vampire0 |
Logged In: YES user_id=918212 Originator: YES I would suggest to use _getFile() in both cases and to remove this ugly workaround. I think the preferred way should be to fix the VFSs that have broken implementations and not to work around the wrong implementations. We really should start to write JUnit tests for jEdit, then there could be test that verify a VFS e. g. and verify if the _getFile implementation is ok or not, ... See what I mean? :-) |